Repository navigation
refactor(ui): QueryaSpinner, QueryaBadge and the tree loading row off shadcn - #1412
Merged
ZhuchkaTriplesix merged 1 commit intoOct 11, 2026
Merged
Conversation
…longer import shadcn Colours come from the Querya theme scope (material theme as fallback in the spinner), gaps are SizedBoxes and the loading label is a plain Text. The three files leave the shadcn allow-list. Part of #1365.
github-actions
Bot
added
epic
This was referenced Oct 11, 2026
ZhuchkaTriplesix
deleted the
issue/1365-spinner-badge-loadingrow-off-shadcn
branch
October 11, 2026 15:03
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #1365 (does not close it)
First migration under the ratchet guard from #1409: three more files of
lib/shared/widgets/stop importingpackage:shadcn_flutter, and leave the allow-list in the same change (the guard fails if they stay).querya_spinner.dartTheme.of(context).colorScheme,GapQueryaThemeScopeworkbench accent / muted, material theme as the no-scope fallback;SizedBoxquerya_badge.dartTheme.of(context).colorScheme,Gapcontext.queryaTheme.colorScheme(the same scheme the app feeds to its theme),SizedBoxconnection_tree_loading_row.dartText(...).muted().xSmall(),GapTextwith the workbench muted colour at 12 px,SizedBoxNo behaviour change intended: the colours are the same sources (
QueryaTheme.colorSchemeis whattoShadcnThemeDatareceives), the gaps are the same sizes.Not in this PR
The files that need a button (
querya_empty_state,querya_modal_dialog,querya_action_button) wait forQueryaButton(#1408);querya_dialog_carduses shadcn'sradiusXxl; dropdown / search / tab strip / icon button take shadcn'sThemefor their scheme and go as a group once the theme access is settled.Not run locally; CI is the check.